Fix SHA256 used by fetchFromGitHub #57737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
11.by: package-maintainer
ryantm
requested changes
Mar 16, 2019
There was a problem hiding this comment.
Please change the commit message to fit https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md
for example: "junkie: fix src sha256"
|
@GrahamcOfBorg build junkie |
No idea how ever built. TIL about nix-prefetch-url.
|
Fixed commit message. thx! |
ryantm
approved these changes
Mar 16, 2019
|
@GrahamcOfBorg build junkie |
|
Looks good; thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I broke the build with a sha256 obtained from sha256sum like other noobs before me.
No idea how ever built. TIL about nix-prefetch-url.
Things done
Fixed the build, tested both with and without the fix with
nix-env -f $PWD/default.nix -i junkie