Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocaml-syslog: init at 1.5 #57738

Merged
merged 1 commit into from
Mar 19, 2019
Merged

ocaml-syslog: init at 1.5 #57738

merged 1 commit into from
Mar 19, 2019

Conversation

rixed
Copy link
Contributor

@rixed rixed commented Mar 16, 2019

Motivation for this change

Add the ocaml-syslog library (which as the name suggest allow an ocaml program to access UNIX logger).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS (with nix-env -f $PWD --option sandbox true -i ocaml-syslog)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 16, 2019
@vbgl vbgl added 8.has: package (new) This PR adds a new package 6.topic: ocaml labels Mar 16, 2019
@vbgl vbgl merged commit 913e338 into NixOS:master Mar 19, 2019
@rixed rixed deleted the ocaml-syslog branch March 19, 2019 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: ocaml 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants