Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADLPlug: v1.0.0-beta.5 -> v1.0.0 #57744

Merged
merged 1 commit into from Mar 17, 2019
Merged

ADLPlug: v1.0.0-beta.5 -> v1.0.0 #57744

merged 1 commit into from Mar 17, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 16, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 16, 2019
@veprbl
Copy link
Member

veprbl commented Mar 16, 2019

@GrahamcOfBorg build adlplug opnplug

pkgs/applications/audio/adlplug/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/adlplug/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/adlplug/default.nix Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Mar 17, 2019

@ryantm Fixed, thanks!

@veprbl veprbl merged commit 9586811 into NixOS:master Mar 17, 2019
@ghost
Copy link
Author

ghost commented Mar 17, 2019

@veprbl Thank you!

@ghost ghost deleted the adlplug branch March 17, 2019 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants