Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import cross-compilation patch for clock #57748

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Mar 16, 2019

taken form https://github.com/input-output-hk/iohk-nix/blob/master/patches/clock-0.7.2.patch

Motivation for this change

This allows

nix-build -A pkgsCross.musl64.haskellPackages.clock

which maybe eventually allows a static build of cachix.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@nomeata nomeata requested review from basvandijk and peti as code owners March 16, 2019 10:36
@nomeata
Copy link
Contributor Author

nomeata commented Mar 16, 2019

NB: Parts of the patch are already upstream, but not yet released to Hackage: corsis/clock@f7fe4fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants