filesystems: Add autoResize assertion #57751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Assert that autoResize is only used when fsType is explicitly set to a supported filesystem: if it's set to "auto", the default, the required resizing tools won't be copied into the initrd even if the actual filesystem is supported.
GrahamcOfBorg
added
6.topic: nixos
bjornfor
approved these changes
Mar 19, 2019
|
I don't know why you are handling |
|
Confusingly enough, resizing tools are imported for f2fs, but not in stage-1.nix: https://github.com/NixOS/nixpkgs/blob/master/nixos/modules/tasks/filesystems/f2fs.nix |
|
@talyz ok, thanks! |
pull bot
pushed a commit
to evanjs/nixpkgs
that referenced
this pull request
Mar 25, 2019
This otherwise does not eval `:tested` any more, which means no nixos channel updates. Regression comes from 0eb6d07 (NixOS#57751) which added an assertion stopping the use of `autoResize` when the filesystem cannot be resized automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Assert that autoResize is only used when fsType is explicitly set to a
supported filesystem: if it's set to "auto", the default, the required
resizing tools won't be copied into the initrd even if the actual
filesystem is supported.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)