Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brakeman: 4.4.0 -> 4.5.0 #57756

Merged
merged 1 commit into from
Mar 16, 2019
Merged

brakeman: 4.4.0 -> 4.5.0 #57756

merged 1 commit into from
Mar 16, 2019

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Mar 16, 2019

Motivation for this change

Changelog: https://github.com/presidentbeef/brakeman/releases/tag/v4.5.0

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

@GrahamcOfBorg build brakeman

@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 16, 2019
@srhb
Copy link
Contributor

srhb commented Mar 16, 2019

Built locally. Should this be backported to 19.03?

@srhb srhb merged commit 106db71 into NixOS:master Mar 16, 2019
@marsam
Copy link
Contributor Author

marsam commented Mar 17, 2019

Thanks!

Should this be backported to 19.03?

I don't it's necessary, it does not contains mayor bugfixes

@marsam marsam deleted the update-brakeman branch March 17, 2019 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marsam @srhb @GrahamcOfBorg