Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

radiotray-ng: 0.2.4 -> 0.2.5 #57761

Merged
merged 2 commits into from
Mar 17, 2019
Merged

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 16, 2019

patch to use provided gtest/gmock, fix+enable tests

Motivation for this change

Update!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

patch to use provided gtest/gmock, fix+enable tests
@GrahamcOfBorg GrahamcOfBorg added 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 16, 2019
@xeji
Copy link
Contributor

xeji commented Mar 16, 2019

Works fine here (x86-llnux) but the test failure on aarch64 should be fixed before we merge.

@dtzWill dtzWill merged commit 4f7a762 into NixOS:master Mar 17, 2019
@dtzWill dtzWill deleted the update/radiotray-ng-0.2.5 branch March 17, 2019 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants