Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hardinfo: fix not finding libc #57771

Merged
merged 1 commit into from
Mar 17, 2019
Merged

Conversation

OPNA2608
Copy link
Contributor

@OPNA2608 OPNA2608 commented Mar 16, 2019

Motivation for this change

On NixOS 18.09 (I don't think master behaves differently), running hardinfo from a terminal and accessing the "Summary" section under "Computer" will show an error in said terminal that accessing /lib/libc.so.6 failed.

This PR fixes this by substituteInPlaceing the affected line with ${stdenv.glibc.out}/lib/libc.so.6 (taken from other packages' solutions). The message goes away, though the report does not appear to have changed…


There is another error message when accessing the Battery option under Devices, where it will repeatedly print

sh: -c: This option requires an argument.

that I don't know how to fix, but it's more likely to get fixed in this much newer fork, problem being that there hasn't been a release since 0.5.1 in 2009 either because of some minor blockers.

Perhaps we should consider switching to that fork and pinning a recent commit like Ubuntu did instead of waiting for upstream to publish a new version after 10 years of code changes since 0.5.1.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from bjornfor March 16, 2019 22:52
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 16, 2019
@bjornfor bjornfor merged commit 4708d3f into NixOS:master Mar 17, 2019
@OPNA2608 OPNA2608 deleted the hardinfo_glibc_fix branch April 27, 2020 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants