Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Giada: initialize at 0.15.4 #58233

Closed
wants to merge 3 commits into from
Closed

Giada: initialize at 0.15.4 #58233

wants to merge 3 commits into from

Conversation

@Zer0-
Copy link
Contributor

Zer0- commented Mar 25, 2019

Motivation for this change

Giada is not in nixpkgs, it is one of the more capable sound looping programs on linux right now.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Zer0- Zer0- changed the title Giada2 Giada: initialize at 0.15.4 Mar 25, 2019
pkgs/applications/audio/giada/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/giada/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/giada/default.nix Outdated Show resolved Hide resolved
pkgs/applications/audio/giada/default.nix Outdated Show resolved Hide resolved
- change license to gplv3+
- don't override buildPhase
- move build tools into nativeBuildInputs
- other minor fixes
@Zer0-
Copy link
Contributor Author

Zer0- commented Mar 25, 2019

@jtojnar OK, Thank you for the feedback. I've made changes towards good practices.

@Zer0-
Copy link
Contributor Author

Zer0- commented May 2, 2019

"This PR breaks listing of package outputs after merging. " what does this mean?

@aanderse
Copy link
Contributor

aanderse commented Jul 16, 2019

Copy link
Contributor

aanderse left a comment

@Zer0- looks like an evaluation error. Please correct.

'';
homepage = https://www.giadamusic.com;
platforms = platforms.linux;
license = lib.licenses.gpl3Plus;

This comment has been minimized.

Copy link
@aanderse

aanderse Jul 17, 2019

Contributor

remove lib..

@prusnak
Copy link
Member

prusnak commented May 9, 2020

Giada has been packaged since cb0b0e9

@prusnak prusnak closed this May 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.