Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] thunderbird: 60.5.1 -> 60.6.0 #58352

Merged
merged 2 commits into from Apr 12, 2019

Conversation

Projects
None yet
4 participants
@andir
Copy link
Member

commented Mar 26, 2019

Motivation for this change

Backport of the backport #58034 :-)

cc @Mic92 @taku0

I haven't built it yet - lack of (mobile) computation power & no access to private keys..

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

taku0 added some commits Mar 1, 2019

thunderbird: 60.5.1 -> 60.5.2
(cherry picked from commit 202f713)
thunderbird: 60.5.2 -> 60.6.0
(cherry picked from commit 3c83eb4)
@taku0

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2019

It works.

git fetch --force upstream pull/58352/head:pull_58352
git checkout pull_58352
nix-build --keep-failed --keep-going -I nixpkgs=. -o thunderbird -A pkgs.thunderbird
./thunderbird/bin/thunderbird

@andir andir merged commit 28c1496 into NixOS:release-18.09 Apr 12, 2019

12 of 14 checks passed

thunderbird on x86_64-darwin No attempt
Details
thunderbird on x86_64-linux Timed out, unknown build status
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
thunderbird on aarch64-linux Success
Details

@andir andir deleted the andir:18.09/thunderbird branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.