Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fontforge: 20170730 -> 20190317 #58415

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
6 participants
@dtzWill
Copy link
Contributor

commented Mar 26, 2019

Motivation for this change

https://github.com/fontforge/fontforge/releases/tag/20190317

  • add zmq (collab), woff2 (format), readline (cli)
  • "just in case", keep determinism patching
  • fontforge-fonttools: replace with override enabling tools
    Don't see any reason to not include by default,
    so this might make more sense as an alias instead.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

fontforge: 20170730 -> 20190317
https://github.com/fontforge/fontforge/releases/tag/20190317

* add zmq (collab), woff2 (format), readline (cli)
* "just in case", keep determinism patching
* fontforge-fonttools: replace with override enabling tools
  Don't see any reason to not include by default,
  so this might make more sense as an alias instead.

@dtzWill dtzWill requested review from 7c6f434c, abbradar and LnL7 and removed request for 7c6f434c and abbradar Mar 27, 2019

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Mar 27, 2019

@GrahamcOfBorg build creep

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

@GrahamcOfBorg build tlwg ricty liberation-sans-narrow

@xeji

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@7c6f434c 7c6f434c merged commit 75b1c3a into NixOS:staging Apr 12, 2019

16 of 20 checks passed

creep on x86_64-darwin Timed out, unknown build status
Details
fontforge on x86_64-darwin Timed out, unknown build status
Details
liberation-sans-narrow, ricty, tlwg on aarch64-linux Failure
Details
liberation-sans-narrow, ricty, tlwg on x86_64-darwin Timed out, unknown build status
Details
creep on aarch64-linux Success
Details
creep on x86_64-linux Success
Details
fontforge on aarch64-linux Success
Details
fontforge on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
liberation-sans-narrow, ricty, tlwg on x86_64-linux Success
Details
@volth

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Updating fontforge might change sha256 of some FODs in data/fonts (unlikely, but possible), and it won't be detected in our casual workflow because FODs are not going to rebuild.

Someone, who does not have cache.nixos.org in her list of binary caches eventually might get a strange hash mismatch (and those who have cache.nixos.org in the list will get cached fonts built with older fontforge)

So, the idea is to force Hydra (or ofborg?) to always rebuild FODs and ensure the output hash is still valid (the test cases are processing3's manual and hadoop whose fetchurl hashes have been changs)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.