Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

emacs: only use patchelf on linux #58472

merged 1 commit into from Mar 28, 2019


Copy link

Motivation for this change

This prevents building Emacs with X on Darwin.

Broken by 5af6e9f (#54916)

Is stdenv.isLinux the correct guard for patchelf?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

This prevents building Emacs with X on Darwin.

Broken by 5af6e9f (NixOS#54916)
Copy link

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


@matthewbauer matthewbauer merged commit 45dbb34 into NixOS:master Mar 28, 2019
@thefloweringash thefloweringash deleted the emacs-x-darwin branch May 1, 2019 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants