Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gandom-fonts: init at v0.6 #58493

merged 1 commit into from Mar 29, 2019

gandom-fonts: init at v0.6 #58493

merged 1 commit into from Mar 29, 2019


Copy link

@LinArcX LinArcX commented Mar 28, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

{ stdenv, fetchFromGitHub }:

stdenv.mkDerivation rec {
name = "gandom-fonts";
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name is of the form PackageName-Version, you might mean pname here

Suggested change
name = "gandom-fonts";
pname = "gandom-fonts";

gandom-fonts: init at v0.6
@vbgl vbgl merged commit 6b1d7e9 into NixOS:master Mar 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants