Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wine{unstable,staging,mono,winetricks} #58506

Merged
merged 4 commits into from Apr 16, 2019

Conversation

Projects
None yet
6 participants
@nyanloutre
Copy link
Contributor

commented Mar 28, 2019

Motivation for this change
  • wine{unstable,staging}: 4.2 -> 4.5
  • wine-mono: 4.7.5 -> 4.8.0
  • winetricks: 20181203 -> 20190310
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

nyanloutre added some commits Mar 28, 2019

@nyanloutre

This comment has been minimized.

Copy link
Contributor Author

commented Mar 29, 2019

I tested wineWowPackages.unstable successfully

@tadeokondrak tadeokondrak referenced this pull request Apr 3, 2019

Closed

Wine updates #58878

1 of 10 tasks complete
Show resolved Hide resolved pkgs/misc/emulators/wine/sources.nix Outdated
Show resolved Hide resolved pkgs/misc/emulators/wine/sources.nix Outdated
wine{unstable,staging}: 4.4 -> 4.5
Co-Authored-By: nyanloutre <paul@nyanlout.re>
@nyanloutre

This comment has been minimized.

Copy link
Contributor Author

commented Apr 5, 2019

If you want to test, I pushed some packages to cachix : https://nyanloutre.cachix.org/

  • wineWowPackages.unstable
  • wine
  • winetricks
@ikervagyok

This comment has been minimized.

Copy link
Contributor

commented Apr 15, 2019

why does it always take such a long time until wine updates get merged? wine 4.6 is already out (also staging). anyway - would you update and then we find someone to finally commit these changes?

@veprbl

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@GrahamcOfBorg build wine winePackages.staging winePackages.full

@veprbl

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

@nyanloutre

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@veprbl the borg build usually timeout because wine is taking more than an hour to build

@veprbl

veprbl approved these changes Apr 16, 2019

@veprbl

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Passes nix-review, winemine works.

@veprbl veprbl merged commit 04ff994 into NixOS:master Apr 16, 2019

11 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@nyanloutre

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

@ikervagyok I made a PR for 4.6 here : #59764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.