Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos: make hardware.enableAllFirmware enable *all* firmware #58509

merged 1 commit into from Apr 3, 2019


Copy link

Motivation for this change

otherwise the name is misleading.

Things done
  • booted a vm with enableAllFirmware = true and nothing obviously wrong was in dmesg
  • checked that enableRedistributableFirmware evaluates without allowUnfree
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

What's the closure size difference for a system with this option enabled?

Copy link
Member Author

Considering the closure size of the result of nixos-rebuild build-vm on the following configuration:

{ config, pkgs, ... }:
  boot.loader.grub.enable = true;
  boot.loader.grub.version = 2;
  hardware.enableAllFirmware = true;
  users.users.root.initialPassword = "foo";
  system.stateVersion = "19.03"; # Did you read the comment?
  nixpkgs.config.allowUnfree = true;

before: 1714696288
after: 1742443672
a difference of 26M.

Copy link

Sounds good. Maybe it would be a good idea to put all firmware under pkgs.firmware.*, such that we can include all attributes of it directly, instead of having to list each one of them here. This would also make it future-proof, when new firmware is added.

Copy link
Member Author

This may be a good thing. Introducing a scope like this would make overrides trickier, though. In any case, this probably belongs to another PR.

@infinisil infinisil merged commit c978593 into NixOS:master Apr 3, 2019
@symphorien symphorien deleted the all-fw branch May 18, 2019 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants