Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freediag: init at unstable-2019-02-18 #58594

wants to merge 1 commit into from


Copy link

@bignaux bignaux commented Mar 30, 2019

Motivation for this change

unstable-2019-02-18 since @fenugrec had not released since some years and later the better!

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits

Copy link

@fenugrec fenugrec commented Mar 31, 2019

Yeah yeah, I have a new release "soon"... seriously just need to test it on my test ECUs before I package the release P)

Last changes probably shouldn't affect your distro packaging though.

[EDIT] P.S. you can probably safely drop the BUILDGUI option and thus the fltk dependency, I haven't ever heard of anyone actually using the gui succesfully in the 10 years I've been involved in freediag !

nativeBuildInputs = [ cmake pkgconfig ];
buildInputs = [ fltk libGL ];

cmakeFlags = [ "-DBUILD_GUI=1" ];
Copy link

@ryantm ryantm Apr 2, 2019

The upstream maintainer fenugrec recommends dropping this config.

Suggested change
cmakeFlags = [ "-DBUILD_GUI=1" ];

Copy link

@stale stale bot commented Jun 2, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on

@stale stale bot added the 2.status: stale label Jun 2, 2020
@bignaux bignaux closed this Oct 13, 2020
@bignaux bignaux deleted the freediag branch Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants