Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

yarn2nix: move to aliases.nix #58595

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@worldofpeace
Copy link
Member

commented Mar 30, 2019

Motivation for this change

IIRC that's where things like this belonged.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace worldofpeace force-pushed the worldofpeace:yarn2nix-alias branch from 0cfe362 to 32fc68d Apr 12, 2019

@worldofpeace worldofpeace merged commit 78d5ba3 into NixOS:master Apr 12, 2019

1 check was pending

grahamcofborg-eval Cloning project
Details

@worldofpeace worldofpeace deleted the worldofpeace:yarn2nix-alias branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.