Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] iso-image: make reproducible by not relying on mcopy's readdir #58694

Closed
wants to merge 1 commit into from

Conversation

@Ekleog
Copy link
Member

Ekleog commented Apr 1, 2019

Motivation for this change

#57559, but that doesn't actually break stuff.

Don't merge until nix-build nixos/release.nix -A tests.boot.uefiUsb passes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

# Copy the files
# Note: we can't use mcopy's recursive copying as it uses `readdir` order.
# So just copy file-after-file

This comment has been minimized.

Copy link
@bjornfor

bjornfor Sep 15, 2019

Contributor

Another option is to use fatsort. (Just FYI.)

@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.
@stale stale bot added the 2.status: stale label Jun 1, 2020
@Ekleog
Copy link
Member Author

Ekleog commented Jun 1, 2020

Looks like I don't have the time to finish this off… well, anyone, feel free to take over, at least the non-reproducibility source is pointed out by the comments in the code of this PR, even though the way I tried to fix it apparently makes nixosTests.boot.uefiUsb fail to succeed for some reason :)

@Ekleog Ekleog closed this Jun 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.