Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HylaFAX: fix ModemGroup, also minor metadata updates #59081

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@Yarny0
Copy link
Contributor

commented Apr 6, 2019

Motivation for this change

HylaFAX+ handles the ModemGroup parameter differently from the way the relevant manpage claims it is handled. This can lead to stuck jobs.
I'm using this opportunity to update/improve further minor aspects of the HylaFAX package and module.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (no tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip" (no need)
  • Tested execution of all binary files (usually in ./result/bin/) (no need)
  • Determined the impact on package closure size (by running nix path-info -S before and after) (no change)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

At least the ModemGroup commit should be applied to release-19.03 as well. The other might be backported also as they change metadata only. Should I open a separate pull request for 19.03 ?

@Infinisil

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

What's the motivation behind switching from sha256 -> sha512?

@Yarny0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 11, 2019

What's the motivation behind switching from sha256 -> sha512?

That's just a feeling in my gut that sha512 is certainly no less reliable, possibly more one day. There is not need for this change beyond.

We can also drop this commit .. should we? Should I replace the pull request?

@Infinisil

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Well currently the auto-update bot (@r-ryantm) at least only works for sha256, and all nix prefetching scripts output sha256 by default, so I think it might be better to keep using sha256. You don't need to replace the PR, you can just remove that commit with a git rebase -i HEAD~4 or so

Yarny0 added some commits Apr 5, 2019

nixos/hylafax: add 'yarny' (= myself) as maintainer
I forgot to do this when I submitted this module with
commit 12fa95f.
nixos/hylafax: fix faxq `ModemGroup` setting
The manpage claims that the "limit" in the setting::
  <name>:[<limit>:]<regex>
is optional and defaults to zero, implying no limit.
However, tests confirmed that it actually isn't optional.

Without limit, the setting ``any:.*`` places
outbound jobs on infinite hold if no particular
modem was specified on the sendfax command line.
The new default value ``any:0:.*`` from
this commit uses any available modem to
send jobs if not modem was given to sendfax.
hylafaxplus: update meta
* move meta attrset into curly brackets
* update homepage (finally supports https)
* add downloadPage
* add longDescription

@Yarny0 Yarny0 force-pushed the Yarny0:hylafax-updates branch from bd14418 to 729ce1c Apr 12, 2019

@Yarny0

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

Well currently the auto-update bot (@r-ryantm) at least only works for sha256
Aha, I didn't know that, that's a good reason to keep it sha256. Thanks for this information. I dropped the respective commit.

@Infinisil Infinisil merged commit 92ae299 into NixOS:master Apr 12, 2019

10 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Yarny0 Yarny0 deleted the Yarny0:hylafax-updates branch Apr 24, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.