Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

networkmanager-l2tp: 1.2.12 -> 1.7.0-dev #59250

Closed
wants to merge 1 commit into from
Closed

Conversation

@teto
Copy link
Contributor

teto commented Apr 10, 2019

I don't know what's the nixos policy regarding this release: it follows gnome rules and thus the odd version number indicates an unstable release.
Also the homepage contains a license warning https://github.com/nm-l2tp/NetworkManager-l2tp so it might be best to wait for an openssl 3 release before actually merging.
Meanwhile this is here for those who want to try and to prevent duplicate work. It works for me.
The closure size should increase as the package now requires openssl and nss.

Among the new features:
Adds user or machine TLS certificate support with L2TP/IPsec VPN servers cf:
https://github.com/nm-l2tp/NetworkManager-l2tp/blob/master/NEWS

This check has been added in nm-l2tp/NetworkManager-l2tp@56e82af,
i.e. l2tp version 1.7.0.

The source is not the exact 1.7.0 since a commit was added afterwards to work around nixos limitations.:
nm-l2tp/NetworkManager-l2tp@8a72e8f

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Adds user or machine TLS certificate support with L2TP/IPsec VPN servers cf:
https://github.com/nm-l2tp/NetworkManager-l2tp/blob/master/NEWS

This check has been added in nm-l2tp/NetworkManager-l2tp@56e82af,
    i.e. l2tp version 1.7.0.

Not the exact 1.7.0 since a commit was added afterwards to work around nixos limitations.
@worldofpeace
Copy link
Member

worldofpeace commented Apr 10, 2019

I don't know what's the nixos policy regarding this release: it follows gnome rules and thus the odd version number indicates an unstable release.
Meanwhile this is here for those who want to try and to prevent duplicate work. It works for me.

We shouldn't merge it at an unstable release.
But yeah, that doesn't mean we shouldn't test unstable releases and get our work out the door for a draft.

@teto
Copy link
Contributor Author

teto commented May 17, 2020

I dont use l2tp anymore: closing.

@teto teto closed this May 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.