Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python.pkgs.pytest-watch: init at 4.2.0 #59295

Open
wants to merge 3 commits into
base: master
from

Conversation

@sveitser
Copy link
Contributor

commented Apr 11, 2019

Motivation for this change

Add pytest-watch.

Tested commands ptw and pytest-watch successfully with python2 and 3.7 on a small test project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sveitser sveitser requested a review from FRidh as a code owner Apr 11, 2019

@adisbladis

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

Are you packaging this to use it for some other package you will submit later? In that case, it would be nice to put it all in a single PR.

dotlambda and others added some commits Apr 14, 2019

Apply suggestions from code review
Co-Authored-By: sveitser <sveitser@gmail.com>
@sveitser

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Are you packaging this to use it for some other package you will submit later? In that case, it would be nice to put it all in a single PR.

No, I would just like to package pytest-watch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.