Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taffybar: unbreak package by default #59305

Closed
wants to merge 6 commits into from

Conversation

Projects
None yet
6 participants
@mdorman
Copy link
Contributor

commented Apr 11, 2019

@peti The gtk library situation seems to have been resolved, so it builds again.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

peti and others added some commits Apr 7, 2019

hackage-packages.nix: automatic Haskell package set update
This update was generated by hackage2nix v2.14.2-5-g11c68fd from Hackage revision
commercialhaskell/all-cabal-hashes@3d5bbe3.
haskell-generic-builder: disable library-for-ghci by default
This commit disables the library-for-ghci flag passed to
`Setup configure` in the Haskell generic-builder.nix file.

This stops the HSfoo.o file from being built.  Building this
HSfoo.o file caused doctest to take an extremely long time
to load dependencies when running.

This is a follow-up from #58743.
taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds
again.
@pSub

This comment has been minimized.

Copy link
Member

commented Apr 11, 2019

@GrahamcOfBorg build haskellPackages.taffybar

@pSub
Copy link
Member

left a comment

Not sure if I'm doing something wrong, but at least ofBorg still refuses to build taffy bar

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.
@Infinisil

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

@pSub This change here will only be applied once hackage-packages.nix gets regenerated. The file changed here is the configuration for that auto-generator.

@Infinisil

This comment has been minimized.

Copy link
Contributor

commented Apr 11, 2019

For reference, the fix for taffybar was in #57095

@peti peti force-pushed the NixOS:haskell-updates branch 2 times, most recently from af9da77 to 08114c6 Apr 11, 2019

peti added a commit that referenced this pull request Apr 12, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.

@peti peti force-pushed the NixOS:haskell-updates branch from 3baf7a6 to c19317b Apr 12, 2019

peti added a commit that referenced this pull request Apr 12, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.
@peti

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Merged in e910657.

@peti peti closed this Apr 12, 2019

peti added a commit that referenced this pull request Apr 13, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.

peti added a commit that referenced this pull request Apr 13, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.

peti added a commit that referenced this pull request Apr 13, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.

peti added a commit that referenced this pull request Apr 13, 2019

taffybar: unbreak package by default
The gtk package situation seems to have been resolved, so it builds again.

Closes #59305.
@pSub

This comment has been minimized.

Copy link
Member

commented Apr 13, 2019

@pSub This change here will only be applied once hackage-packages.nix gets regenerated. The file changed here is the configuration for that auto-generator.

Thank you for the explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.