Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

steam: fix steamrt trying to use a missing setup.sh #59326

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@puffnfresh
Copy link
Contributor

commented Apr 11, 2019

I was getting the following error after a Steam update:

internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

steam: fix steamrt trying to use a missing setup.sh
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.
@benley

benley approved these changes Apr 15, 2019

Copy link
Member

left a comment

I ran into the same issue and this fixed it for me, thank you

@benley benley merged commit 098cf3b into NixOS:master Apr 16, 2019

11 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@baracoder

This comment has been minimized.

Copy link
Contributor

commented Apr 16, 2019

Is it required to backport for 19.03?

@benley

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

Is it required to backport for 19.03?

I think so, yes. Totally forgot that the system where I encountered it was running 19.03.

@matthew-piziak

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Is this part of https://github.com/NixOS/nixpkgs-channels/archive/nixos-unstable.tar.gz? I'm not sure if I'm reading this right: http://howoldis.herokuapp.com/

In any case I am still getting this error on that channel.

@benley

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

It looks like it hasn't made its way into nixos-unstable yet, but it does show up in the nixos-unstable-small channel if you want to try that one. Personally I just cherry-picked the commit onto a local checkout of nixos-unstable (from https://github.com/NixOS/nixpkgs-channels)

@matthew-piziak

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

Oh interesting. I think I know how to do that. If I fork nixpkgs-channels then I can make my own tarball to pull. Thank you @benley!

@benley

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Also technically you don't need to make a tarball if you just want to use it locally. You can do something like nixos-rebuild -I nixpkgs=~/path/to/nixpkgs-channels and it will build using your working copy on disk.

@matthew-piziak

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

For the record nixpkgs-unstable-small works perfectly. Thanks!

And yeah, that's true but I'd rather have something hosted than I can share between machines; and something in my configuration.nix, since I like things specified in a version-controlled file, rather than ephemerally in a command line argument. Nevertheless thank you for the suggestion!

srhb added a commit to srhb/nixpkgs that referenced this pull request Apr 18, 2019

steam: fix steamrt trying to use a missing setup.sh (NixOS#59326)
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

(cherry picked from commit 098cf3b)

@srhb srhb referenced this pull request Apr 18, 2019

Merged

[19.03] steam: fix steamrt trying to use a missing setup.sh #59822

0 of 10 tasks complete

@jethrokuan jethrokuan referenced this pull request Apr 18, 2019

Merged

steamrt 1.1 -> 1.2 #59838

3 of 10 tasks complete

Tomahna added a commit to Tomahna/nixpkgs that referenced this pull request Apr 19, 2019

steam: fix steamrt trying to use a missing setup.sh (NixOS#59326)
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

thomasjm added a commit to codedownio/nixpkgs that referenced this pull request Apr 24, 2019

steam: fix steamrt trying to use a missing setup.sh (NixOS#59326)
I was getting the following error after a Steam update:

    internal error: /steamrt/setup.sh is missing, this runtime is invalid or corrupted

The script is used to put things on PATH but it doesn't seem we need to do that.

(cherry picked from commit 098cf3b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.