Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: update 17.03 -> 19.03 in upgrading section #59349

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@mogorman
Copy link
Contributor

commented Apr 12, 2019

Motivation for this change

The manual references 17.03 in a few spots in the upgrading section of the manual. I think it makes sense to keep those references current as there are a lot of copy and paste warriors out there and it would be nice to make upgrading as easy as possible.

Things done

changed 17.03 -> 19.03 , and updated example to accurately cover this change as well

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

In these docs is also a "release process" to do list. Could you add this task to that to-do list?

@mogorman mogorman force-pushed the mogorman:manual-upgrading branch from f5144ea to da035d3 Apr 12, 2019

@mogorman

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@grahamc made update to release process as well. great call.

@grahamc grahamc merged commit 628ba24 into NixOS:master Apr 12, 2019

@grahamc

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Mind opening a backport PR? :) to 19.03

@mogorman mogorman deleted the mogorman:manual-upgrading branch Apr 12, 2019

mogorman added a commit to mogorman/nixpkgs that referenced this pull request Apr 12, 2019

Merge pull request NixOS#59349 from mogorman/manual-upgrading
nixos/manual: update 17.03 -> 19.03 in upgrading section
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.