Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.lektor: 2.3 -> 3.1.3 #59353

Merged
merged 3 commits into from Apr 14, 2019

Conversation

Projects
None yet
5 participants
@costrouc
Copy link
Contributor

commented Apr 12, 2019

Motivation for this change

Company is deploying a lektor based blog wanted to have the latest lektor version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner Apr 12, 2019

costrouc added some commits Apr 12, 2019

@costrouc costrouc force-pushed the costrouc:python-lektor-upgrade branch from 3d15aca to dec2bae Apr 12, 2019

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2019

@GrahamcOfBorg build python2Packages.lektor python2Packages.pytest-pylint python2Packages.click python3Packages.lektor python3Packages.pytest-pylint python3Packages.click

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented Apr 14, 2019

Ready for merge.

@xeji xeji merged commit 61327db into NixOS:master Apr 14, 2019

13 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
python2Packages.click, python2Packages.lektor, python2Packages.pytest-pylint, python3Packages.click, python3Packages.lektor, python3Packages.pytest-pylint on aarch64-linux Success
Details
python2Packages.click, python2Packages.lektor, python2Packages.pytest-pylint, python3Packages.click, python3Packages.lektor, python3Packages.pytest-pylint on x86_64-linux Success
Details

@joachifm joachifm referenced this pull request Apr 18, 2019

Closed

lektor: 2.3 -> 3.1.3 #55818

2 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.