Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ptask: accept versions 2.5.0, 2.5.1, 2.5.2 #59505

Closed
wants to merge 1 commit into from

Conversation

@dtzWill
Copy link
Contributor

dtzWill commented Apr 14, 2019

Motivation for this change

Uh, for those unnamed folks who may or may not be using 2.5.2 O:).

I may have put this together forgetting about an overlay or two...
still, seems reasonable for general use O:).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Infinisil

This comment has been minimized.

Copy link
Member

Infinisil commented Apr 16, 2019

Huh, why do we have this patch in nixpkgs? Would definitely warrant a comment in ./default.nix

@dtzWill

This comment has been minimized.

Copy link
Contributor Author

dtzWill commented Nov 16, 2019

Oops, nevermind. Agreed doesn't belong in nixpkgs, whoops!

@dtzWill dtzWill closed this Nov 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.