Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ghcjs-ng: unbreak - Backport from master #59567

Merged

Conversation

@FPtje
Copy link
Contributor

commented Apr 15, 2019

Motivation for this change

Backport of #58192
ghcjs is marked broken in release-19.03. This is undesirable.
CC from previous pull request: @vaibhavsagar @Ericson2314

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FPtje

This comment has been minimized.

Copy link
Contributor Author

commented Apr 17, 2019

CC @basvandijk as Haskell maintainer

ghcjs-ng: unbreak
(cherry picked from commit e4975aa)

@basvandijk basvandijk force-pushed the LumiGuide:release-19.03-unbreak-ghcjs branch from 9ee8975 to 734211d Apr 21, 2019

@basvandijk

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

@GrahamcOfBorg build haskell.compiler.ghcjs

@basvandijk

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

Dank je @FPtje!

Please use the -x flag when cherry-picking next time. This ensures that a line is appended that says "(cherry picked from commit ...)" to the original commit message in order to indicate which commit this change was cherry-picked from. I've now forced pushed a commit which has this line.

I'll merge when the checks are green.

@FPtje

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

Will do next time! Thanks!

@FPtje

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

building of '/nix/store/q73fa6zmsz1g4a91b2y3x530pikfqnvc-ghc-api-ghcjs-8.6.2.drv' timed out after 3600 seconds

Yeah, ghcjs needs more than an hour to compile.
If it's any help, it #WorksForMe:
2019-04-22-100824_1529x290_scrot

Though I cannot test darwin. With aarch64-linux I'm not sure whether that's supposed to work yet.

@FPtje

This comment has been minimized.

Copy link
Contributor Author

commented May 2, 2019

Any update on this?

@basvandijk basvandijk merged commit 7095449 into NixOS:release-19.03 May 8, 2019

10 of 13 checks passed

haskell.compiler.ghcjs on aarch64-linux Failure
Details
haskell.compiler.ghcjs on x86_64-darwin Timed out, unknown build status
Details
haskell.compiler.ghcjs on x86_64-linux Timed out, unknown build status
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mat8913 mat8913 referenced this pull request Aug 1, 2019
4 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.