Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sndio init and add support #59652

Closed
wants to merge 5 commits into from

Conversation

@ajs124
Copy link
Member

commented Apr 15, 2019

Motivation for this change

I was setting up a distributed audio setup and was evaluating sndio as one of the options. While I did not end up using it, it seems like a really handy tool.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Todo

Add a module. Add tests.


@ajs124

This comment has been minimized.

Copy link
Member Author

commented Apr 16, 2019

mpd maintainers

@astsmtl @Fuuzetsu @ehmry @fpletz: Since the mpd package seems to have a "turn on all the features" philosophy, I just followed that and turned on sndio by default as well. I can obviously change that, if you disagree with that.

mpv maintainers

@AndersonTorres @Fuuzetsu @fpletz: Unlike mpd, mpv seems more conservative in what is on by default, so I choose to leave sndioSupport false, by default.

cmus maintainer

@oxij: You had this as a TODO, from when you rewrote this at the end of 2015. It's here now! :D

@ajs124 ajs124 force-pushed the ajs124:sndio branch from f25e1cb to 33fe40a Apr 16, 2019
@ajs124 ajs124 force-pushed the ajs124:sndio branch from 33fe40a to 42b7f70 Apr 16, 2019
@oxij

This comment has been minimized.

Copy link
Contributor

commented Apr 17, 2019

@ajs124 ajs124 force-pushed the ajs124:sndio branch from 42b7f70 to ac798fc Apr 17, 2019
@ajs124

This comment has been minimized.

Copy link
Member Author

commented Apr 17, 2019

I split it into "bin" and "dev" and assigned libsndio = sndio.dev, does that work for you?

@oxij

This comment has been minimized.

Copy link
Contributor

commented Apr 18, 2019

@ajs124

This comment has been minimized.

Copy link
Member Author

commented Aug 21, 2019

sndio was init'ed by #61742, but didn't add support to any applications. The version in there is also quite out of date.

@ajs124 ajs124 closed this Aug 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.