Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ibus-packages.mozc: pin to protobuf 3.6 (fixes build breakage at HEAD) #59662

Merged
merged 1 commit into from Apr 16, 2019

Conversation

Projects
None yet
5 participants
@delroth
Copy link
Contributor

commented Apr 16, 2019

Motivation for this change

google/mozc#460

mozc currently doesn't build on trunk: https://hydra.nixos.org/build/92239027

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@grahamc

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

cc @7c6f434c did I see you making changes relevant to this?

@7c6f434c

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

I fixed a similar but different problem: protobufc has unreleased upstream fix for a different protobuf API change.

@grahamc

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@GrahamcOfBorg build ibus-packages.mozc

@grahamc

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

turns out it is called:

@GrahamcOfBorg build ibus-engines.mozc

@grahamc grahamc merged commit 3beec4a into NixOS:master Apr 16, 2019

11 checks passed

grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@delroth

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

Thank you! 👍

@Arfrever

This comment has been minimized.

Copy link

commented Apr 20, 2019

Motivation for this change

google/mozc#460

This would be relevant with Protobuf 3.7.0, but not with Protobuf 3.7.1.

https://github.com/protocolbuffers/protobuf/releases/tag/v3.7.1 says:

Avoid marking generated C++ messages as final, though we will do this in a future release

I do not use NixOS, but in Gentoo I have successfully built Mozc with Protobuf 3.7.1.
In https://github.com/NixOS/nixpkgs/blob/985b9e47b8f4e96fcf4dc691e69e7813827b7ee5/pkgs/development/libraries/protobuf/3.7.nix I see:

 version = "3.7.0";

If you update it to 3.7.1, then it should also work...

dywedir pushed a commit to dywedir/nixpkgs that referenced this pull request Apr 22, 2019

c0bw3b added a commit to c0bw3b/nixpkgs that referenced this pull request Apr 22, 2019

@teto teto referenced this pull request Apr 24, 2019

Merged

protobuf: 3.7.0 -> 3.7.1 #60015

3 of 10 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.