Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datadog: update packages #59872

Merged
merged 2 commits into from Apr 27, 2019

Conversation

@Izorkin
Copy link
Contributor

commented Apr 19, 2019

Update datadog packages:

  • datadog agent to 6.11.0;
  • datadog process agent to 6.11.0;

cc @kalbasit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 19, 2019

@GrahamcOfBorg build datadog-agent datadog-process-agent

@c00w

c00w approved these changes Apr 25, 2019

Copy link
Contributor

left a comment

Simple update
-builds via grahamc and nix-review

@nixos-discourse

This comment has been minimized.

Copy link

commented Apr 25, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/22

@Izorkin

This comment has been minimized.

Copy link
Contributor Author

commented Apr 25, 2019

Check with nix-shell -p nix-review --run 'nix-review pr 59872'

these paths will be fetched (0.03 MiB download, 0.10 MiB unpacked):
  /nix/store/h2qzhwdbhxszlj8d15xf4ap85rghbk94-nix-review-2.0.0
copying path '/nix/store/h2qzhwdbhxszlj8d15xf4ap85rghbk94-nix-review-2.0.0' from 'https://cache.nixos.org'...
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/59872/head:refs/nix-review/1
remote: Enumerating objects: 687, done.
remote: Counting objects: 100% (687/687), done.
remote: Compressing objects: 100% (3/3), done.
remote: Total 1448 (delta 684), reused 685 (delta 684), pack-reused 761
Получение объектов: 100% (1448/1448), 547.15 KiB | 1.95 MiB/s, готово.
Определение изменений: 100% (997/997), завершено с 343 локальными объектами.
Из https://github.com/NixOS/nixpkgs
   4a11ce7f261..1011fae581e  master               -> refs/nix-review/0
 + 6af5f4c7804...eb299c01687 refs/pull/59872/head -> refs/nix-review/1  (принудительное обновление)
$ git worktree add /home/lf/.cache/nix-review/pr-59872/nixpkgs 1011fae581e1139ea4c9f3e479d604eb5669c5d9
Preparing worktree (detached HEAD 1011fae581e)
Распаковка файлов: 100% (18925/18925), готово.
HEAD сейчас на 1011fae581e Merge pull request #60142 from peterhoeg/u/rng
$ git merge --no-commit eb299c01687f879e373fd0b98cee5f6b71c6fb8a
Автослияние pkgs/top-level/all-packages.nix
Автоматическое слияние прошло успешно; как и запрашивали, остановлено перед выполнением коммита
$ nix build --no-link --keep-going --max-jobs 24 --option build-use-sandbox true -f /home/lf/.cache/nix-review/pr-59872/build.nix
[3 built, 8 copied (27.2 MiB), 3.2 MiB DL]
https://github.com/NixOS/nixpkgs/pull/59872
2 package were build:
datadog-agent datadog-process-agent

[0.0 MiB DL]
error: build log of '/nix/store/k2jy2xys21f7xqpaq15rcqcgzfxh4yc7-datadog-process-agent-6.11.0.drv' is not available

@c00w

This comment has been minimized.

Copy link
Contributor

commented Apr 25, 2019

@Izorkin - I think that might be a local error on your machine - It seems like it is building succesfully "2 package were build:" - but something about your machine is causing build logs to be inaccessible? "build log of '/nix/store/k2jy2xys21f7xqpaq15rcqcgzfxh4yc7-datadog-process-agent-6.11.0.drv' is not available"

On my machine this seems to work fine.

@Lassulus

This comment has been minimized.

Copy link
Contributor

commented Apr 27, 2019

works for me with nix-review

@Lassulus Lassulus merged commit 75d150f into NixOS:master Apr 27, 2019

13 checks passed

datadog-agent, datadog-process-agent on aarch64-linux Success
Details
datadog-agent, datadog-process-agent on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@Izorkin Izorkin deleted the Izorkin:datadog branch Apr 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.