Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

freecad: 0.17 -> 0.18.1 #59923

Merged
merged 1 commit into from Apr 26, 2019

Conversation

Projects
None yet
4 participants
@lightbulbjim
Copy link
Contributor

commented Apr 20, 2019

Motivation for this change

Updating to the latest version. Some simplification has been possible as FreeCAD now includes XDG config files in its release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tomberek

This comment has been minimized.

Copy link
Contributor

commented Apr 20, 2019

This fails to open a new or existing cad file on non-NixOS (Ubuntu) with this error:

FreeCAD: gl.cpp:2389: const cc_glglue* cc_glglue_instance(int): Assertion `gi->versionstr && "could not call glGetString() -- no current GL context?"' failed.
/home/dev/.nix-profile/bin/nixGLNvidia: line 3:  8594 Aborted                 (core dumped) "$@"

Tried: nixGL and LD_LIBRARY_PATH settings.

@lightbulbjim

This comment has been minimized.

Copy link
Contributor Author

commented Apr 20, 2019

This fails to open a new or existing cad file on non-NixOS (Ubuntu) with this error:

Hmm. I don't have an Ubuntu system to test on, but it does look like the error might have something to do with your video card (I'm guessing Nvidia?). FWIW I'm not seeing the error on my NixOS system with Intel HD 520 graphics.

@lightbulbjim

This comment has been minimized.

Copy link
Contributor Author

commented Apr 24, 2019

@tomberek do you have another system to test this on? Alternatively, can you try doing a normal source build (outside of Nix) on the failing system?

Not sure how else to move this forward...

freecad: 0.17 -> 0.18.1
Notes:
  - boost_python patch has been removed as it's part of the new release.
  - XDG config files have been added as of 0.18 so it's no longer to
  generate the MIME and .desktop files manually.

@lightbulbjim lightbulbjim force-pushed the lightbulbjim:freecad-update branch from 6202539 to 2d82f2e Apr 25, 2019

@gebner

This comment has been minimized.

Copy link
Member

commented Apr 26, 2019

I can't reproduce the GL error either (on NixOS). @tomberek Did you update nixGL? Does this error also happen with an ubuntu build of FreeCAD? This might just be an issue with the nvidia driver, if so this should be reported upstream.

@gebner gebner merged commit 2f383a4 into NixOS:master Apr 26, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

@lightbulbjim lightbulbjim deleted the lightbulbjim:freecad-update branch Apr 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.