Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deepin.dde-polkit-agent: set plugins dir from environment variable #59941

Merged
merged 1 commit into from May 11, 2019

Conversation

@romildo
Copy link
Contributor

@romildo romildo commented Apr 21, 2019

Motivation for this change

deepin.dde-polkit-agent: set plugins dir from environment variable

About packaging deepin for NixOS: #59023

See also #59244 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@romildo romildo force-pushed the fix.deepin.dde-polkit-agent branch from 7214f6e to 8f133f1 May 11, 2019
@romildo
Copy link
Contributor Author

@romildo romildo commented May 11, 2019

Modified the patch so that the environment variable may be a list of directories to look for plugins. This is much more flexible and will facilitate wrapping.

@romildo
Copy link
Contributor Author

@romildo romildo commented May 11, 2019

Submitted upstream: linuxdeepin/dde-polkit-agent#12

@romildo romildo merged commit db1236e into NixOS:master May 11, 2019
16 checks passed
@romildo romildo deleted the fix.deepin.dde-polkit-agent branch May 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants