Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

neopg: 0.0.4 -> 0.0.6 #59942

Merged
merged 1 commit into from Apr 22, 2019

Conversation

Projects
None yet
6 participants
@erictapen
Copy link
Contributor

commented Apr 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c00w

This comment has been minimized.

Copy link
Contributor

commented Apr 21, 2019

Looks good

  • Diff + commit message look good
  • ofBorg built the package
  • nix-review succeeded and the binary works.
@nixos-discourse

This comment has been minimized.

Copy link

commented Apr 21, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/22

@Ekleog
Copy link
Member

left a comment

Usually we only take the latest release published upstream in in nixpkgs, but here the package appears to be out-of-development at least for the time being…

Would it be possible to sum up here (and ideally in the commit message too) the reasons why this upgrade is needed? And if possible link to an issue opened upstream that asks for a release :)

Show resolved Hide resolved pkgs/tools/security/neopg/default.nix Outdated
cp src/neopg $out/bin/neopg
preCheck = ''
find | grep '\.so'
export LD_LIBRARY_PATH=$LD_LIBRARY_PATH:$(pwd)/3rdparty/googletest/googletest:$(pwd)/neopg

This comment has been minimized.

Copy link
@Ekleog

Ekleog Apr 21, 2019

Member

Is the :$(pwd)/neopg required for tests to pass? It'd sound weird to me that it's necessary for tests but not for things to work, though I haven't actually tested it.

This comment has been minimized.

Copy link
@erictapen

erictapen Apr 21, 2019

Author Contributor

Yeah that is the result of quite some trial-and-error. If I omit that export, I get

running tests
check flags: SHELL=/nix/store/yjkch3aia9ny4dq42dbcjrdwqb1y8c33-bash-4.4-p23/bin/bash VERBOSE=y test
Running tests...
/nix/store/rz7c3z0nx2wyj8a7zln46r8zc1x37srq-cmake-3.13.4/bin/ctest --force-new-ctest-process
Test project /build/source
    Start 1: NeopgTest
    Start 2: GpgErrorTest
    Start 3: AssuanTest
    Start 4: GcryptTest
1/7 Test #1: NeopgTest ........................***Failed    0.00 sec
/build/source/neopg/tests/test-libneopg: error while loading shared libraries: libneopg.so: cannot open shared object >

    Start 5: GcryptSecmemTest
2/7 Test #2: GpgErrorTest .....................***Failed    0.00 sec
/build/source/legacy/gpg-error-test: error while loading shared libraries: libgtest_main.so: cannot open shared object>

    Start 6: KsbaTest
3/7 Test #3: AssuanTest .......................***Failed    0.00 sec
/build/source/legacy/assuan-test: error while loading shared libraries: libgtest_main.so: cannot open shared object fi>

    Start 7: NeopgToolTest
4/7 Test #4: GcryptTest .......................***Failed    0.00 sec
/build/source/legacy/gcrypt-test: error while loading shared libraries: libgtest_main.so: cannot open shared object fi>

5/7 Test #5: GcryptSecmemTest .................***Failed    0.00 sec
/build/source/legacy/gcrypt-secmem-test: error while loading shared libraries: libgtest_main.so: cannot open shared ob>

6/7 Test #6: KsbaTest .........................***Failed    0.00 sec
/build/source/legacy/ksba-test: error while loading shared libraries: libgtest_main.so: cannot open shared object file>

7/7 Test #7: NeopgToolTest ....................***Failed    0.00 sec
/build/source/neopg-tool/tests/test-neopg: error while loading shared libraries: libgtest_main.so: cannot open shared >


0% tests passed, 7 tests failed out of 7

Total Test time (real) =   0.01 sec

The following tests FAILED:
          1 - NeopgTest (Failed)
          2 - GpgErrorTest (Failed)
          3 - AssuanTest (Failed)
          4 - GcryptTest (Failed)
          5 - GcryptSecmemTest (Failed)
          6 - KsbaTest (Failed)
          7 - NeopgToolTest (Failed)
Errors while running CTest
make: *** [Makefile:130: test] Error 8
builder for '/nix/store/gb1p2kiqzh6k9zbvi2yjkkijf4bqd862-neopg-0.0.6pre2018-11-10.drv' failed with exit code 2

So the .so files are not found for some reason. Most annoyingly I even can't reproduce that behaviour by manully building the package in a nix-shell.

As the resulting binary neopg executes just fine, I believe that everything is alright.

Show resolved Hide resolved pkgs/tools/security/neopg/default.nix Outdated

@erictapen erictapen referenced this pull request Apr 21, 2019

Closed

Release 0.0.6? #97

@erictapen erictapen force-pushed the erictapen:neopg-0.0.5 branch from 8702a42 to 5c6756d Apr 21, 2019

@erictapen erictapen changed the title neopg: 0.0.4 -> 0.0.5.2018-11-10 neopg: 0.0.4 -> 0.0.6pre2018-11-10 Apr 21, 2019

@erictapen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 21, 2019

@Ekleog Well the reason for bumping to current master is that I didn't manage to get the checkPhase of 0.0.5 right. When I figured out that master builds just fine, I skipped the effort and bumped directly to the most recent commit.

@Ekleog

Ekleog approved these changes Apr 21, 2019

@Ekleog

This comment has been minimized.

Copy link
Member

commented Apr 21, 2019

@erictapen Thank you for the precision! Let's try to wait a bit for an answer from neopg, and don't hesitate to up this when you think they've been given enough time to answer, in like a week or two :)

@erictapen erictapen force-pushed the erictapen:neopg-0.0.5 branch from 5c6756d to 81176f4 Apr 22, 2019

@erictapen

This comment has been minimized.

Copy link
Contributor Author

commented Apr 22, 2019

Upstream made the 0.0.6 release, so here it is ;)

@GrahamcOfBorg build neopg

@erictapen erictapen changed the title neopg: 0.0.4 -> 0.0.6pre2018-11-10 neopg: 0.0.4 -> 0.0.6 Apr 22, 2019

@Infinisil Infinisil merged commit a73f3c8 into NixOS:master Apr 22, 2019

14 of 15 checks passed

neopg on aarch64-linux No attempt
Details
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
neopg on x86_64-linux Success
Details
@Ekleog

This comment has been minimized.

Copy link
Member

commented Apr 22, 2019

Great, thank you and them! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.