Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckb-next: 0.3.2 -> 0.4.2 #60262

Merged
merged 1 commit into from Jan 5, 2020
Merged

ckb-next: 0.3.2 -> 0.4.2 #60262

merged 1 commit into from Jan 5, 2020

Conversation

@kierdavis
Copy link
Contributor

@kierdavis kierdavis commented Apr 26, 2019

Motivation for this change

Requested by a user.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after) - increase by 0.068%
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@kierdavis
Copy link
Contributor Author

@kierdavis kierdavis commented May 9, 2019

Tested that this compiles and boots without error, and successfully detects my Corsair keyboard (Strafe) and mouse (Sabre RGB).

This is now ready for review.

@kierdavis kierdavis marked this pull request as ready for review May 9, 2019
@kierdavis
Copy link
Contributor Author

@kierdavis kierdavis commented May 9, 2019

Note that I hope to push the patches used by this expression upstream at some point.

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 12, 2019

@GrahamcOfBorg build ckb-next

@kierdavis kierdavis force-pushed the kierdavis:ckb-next-0.4.0 branch from 685c579 to 2c5c37a Aug 27, 2019
@kierdavis kierdavis changed the title ckb-next: 0.3.2 -> 0.4.0 ckb-next: 0.3.2 -> 0.4.1 Aug 27, 2019
@kierdavis
Copy link
Contributor Author

@kierdavis kierdavis commented Aug 27, 2019

Updated from 0.4.0 to 0.4.1 and fixed conflicts.

@mmahut
Copy link
Member

@mmahut mmahut commented Aug 27, 2019

@GrahamcOfBorg build ckb-next

@Ekleog
Copy link
Member

@Ekleog Ekleog commented Dec 23, 2019

(triage) @kierdavis Looks like there's been another merge conflict since @mmahut ran the ofborg build :/

@kierdavis kierdavis force-pushed the kierdavis:ckb-next-0.4.0 branch from 2c5c37a to 7fb2103 Jan 2, 2020
@kierdavis kierdavis changed the title ckb-next: 0.3.2 -> 0.4.1 ckb-next: 0.3.2 -> 0.4.2 Jan 2, 2020
@kierdavis
Copy link
Contributor Author

@kierdavis kierdavis commented Jan 2, 2020

Rebased and updated to latest version 0.4.2, please review

Copy link
Contributor

@Br1ght0ne Br1ght0ne left a comment

diff LGTM
executable runs, shows GUI

[4 built, 230 copied (889.7 MiB), 193.3 MiB DL]
https://github.com/NixOS/nixpkgs/pull/60262
1 package built:
ckb-next
@Ekleog
Copy link
Member

@Ekleog Ekleog commented Jan 5, 2020

Looks all good, thanks!

@Ekleog Ekleog merged commit 8440abe into NixOS:master Jan 5, 2020
15 checks passed
15 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
ckb-next on aarch64-linux Success
Details
ckb-next on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.