Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

wxwidgets 3.1.0 -> 3.1.2 #60331

Closed
wants to merge 1 commit into from

Conversation

@lasandell
Copy link
Contributor

commented Apr 27, 2019

Motivation for this change

Need this dependency for another package I'm working on. 馃槃

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

It might make sense to just get rid of the 3.0 package and put everything in the 3.1 directory. We'd need to verify everything still works though.

@matthewbauer

This comment has been minimized.

Copy link
Member

commented Apr 27, 2019

@GrahamcOfBorg build wxGTK30 wxGTK31 pwsafe

@lasandell lasandell referenced this pull request Apr 27, 2019
4 of 10 tasks complete
@lasandell

This comment has been minimized.

Copy link
Contributor Author

commented Apr 27, 2019

Looks like it's going to break things, unfortunately. I had to work around the fact that there was no --enable-compat26 flag in 3.1.2. Also looks like there is some error with --enable-universal-binaries missing on x86_64-darwin.

@lasandell lasandell closed this Aug 26, 2019
@lasandell

This comment has been minimized.

Copy link
Contributor Author

commented Aug 26, 2019

Resolved by #63423

@lasandell lasandell deleted the lasandell:wxwidgets-3.1.2 branch Aug 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.