Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metals: init at 0.7.6 #60336

Merged
merged 1 commit into from Jan 4, 2020
Merged

metals: init at 0.7.6 #60336

merged 1 commit into from Jan 4, 2020

Conversation

@Tomahna
Copy link
Contributor

@Tomahna Tomahna commented Apr 27, 2019

Things done

Initialize metals package. Note that this package includes wrappers for vim, sublime and emacs written according to the package documentation. As I only use emacs, it's the only one properly tested.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Tomahna
Copy link
Contributor Author

@Tomahna Tomahna commented Apr 27, 2019

@chrilves if you want to give it a try, there it is

@Tomahna Tomahna force-pushed the Tomahna:metals branch 2 times, most recently from bc49b46 to 2448422 May 8, 2019
@Tomahna Tomahna changed the title metals: init at 0.5.1 metals: init at 0.5.2 May 13, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch 2 times, most recently from 88c8460 to ba63c58 May 13, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch 2 times, most recently from 54c8a1c to d8f81ba Jun 11, 2019
@Tomahna Tomahna changed the title metals: init at 0.5.2 metals: init at 0.6.0 Jun 11, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch from d8f81ba to 46bad4e Jun 12, 2019
@Tomahna Tomahna changed the title metals: init at 0.6.0 metals: init at 0.6.1 Jun 12, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch from 46bad4e to 37e22d1 Jun 29, 2019
@Tomahna Tomahna mentioned this pull request Jul 22, 2019
0 of 10 tasks complete
@Tomahna Tomahna closed this Sep 9, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch from 37e22d1 to bcc8db0 Sep 9, 2019
@Tomahna Tomahna changed the title metals: init at 0.6.1 metals: init at 0.7.2 Sep 9, 2019
@Tomahna Tomahna reopened this Sep 10, 2019
@lheckemann lheckemann added this to the 20.03 milestone Sep 10, 2019
Copy link
Contributor

@ceedubs ceedubs left a comment

👍 LGTM and is similar to a derivation for Metals that I've been using.

@Tomahna please feel free to also add me as a maintainer.

@Tomahna Tomahna force-pushed the Tomahna:metals branch from 5ff90b8 to 5b87782 Sep 11, 2019
@ofborg ofborg bot requested a review from ceedubs Sep 11, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch from 5b87782 to d7a418c Sep 23, 2019
@Tomahna Tomahna changed the title metals: init at 0.7.2 metals: init at 0.7.6 Sep 23, 2019
@ofborg ofborg bot requested a review from ceedubs Sep 23, 2019
@Tomahna Tomahna force-pushed the Tomahna:metals branch from d7a418c to 9a96607 Sep 24, 2019
@ofborg ofborg bot requested a review from ceedubs Sep 24, 2019
Copy link
Contributor

@ceedubs ceedubs left a comment

🎉

@nixos-discourse
Copy link

@nixos-discourse nixos-discourse commented Nov 18, 2019

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/69

@ryantm
Copy link
Member

@ryantm ryantm commented Jan 4, 2020

@GrahamcOfBorg build metals

@ryantm ryantm merged commit bd62dd3 into NixOS:master Jan 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
metals on aarch64-linux Success
Details
metals on x86_64-darwin Success
Details
metals on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants
You can’t perform that action at this time.