Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tmux-xpanes: init at 4.1.0 #60390

Merged
merged 1 commit into from Jan 4, 2020
Merged

tmux-xpanes: init at 4.1.0 #60390

merged 1 commit into from Jan 4, 2020

Conversation

@monsieurp
Copy link
Member

@monsieurp monsieurp commented Apr 28, 2019

  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
@monsieurp monsieurp force-pushed the monsieurp:new-tmux-panes branch 4 times, most recently from 4aa86df to e5d95f1 Apr 29, 2019
@monsieurp monsieurp force-pushed the monsieurp:new-tmux-panes branch from e5d95f1 to 27fc24a Apr 30, 2019
@monsieurp
Copy link
Member Author

@monsieurp monsieurp commented Apr 30, 2019

✔️

@monsieurp
Copy link
Member Author

@monsieurp monsieurp commented May 6, 2019

@grahamc: Hi! Could you take a look at this PR if you get round to it? Thanks! :)

Copy link
Contributor

@gazally gazally left a comment

I built this and tried out the ping example from the homepage and everything worked.

'';

meta = with stdenv.lib; {
description = "tmux-based terminal divider";

This comment has been minimized.

@gazally

gazally Jul 13, 2019
Contributor

Suggested change
description = "tmux-based terminal divider";
description = "Awesome tmux-based terminal divider";

This is what they call it on their homepage, and it fits the CONTRIBUTING.md rule better.

@ryantm
Copy link
Member

@ryantm ryantm commented Jan 4, 2020

@GrahamcOfBorg build tmux-xpanes

@ryantm ryantm merged commit ceb515d into NixOS:master Jan 4, 2020
16 checks passed
16 checks passed
Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
tmux-xpanes on aarch64-linux Success
Details
tmux-xpanes on x86_64-darwin Success
Details
tmux-xpanes on x86_64-linux Success
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
You can’t perform that action at this time.