Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bfs: 1.3.3 -> 1.4 #60474

Merged
merged 1 commit into from May 12, 2019

Conversation

@r-ryantm
Copy link
Contributor

commented Apr 30, 2019

Semi-automatic update generated by https://github.com/ryantm/nixpkgs-update tools. This update was made based on information from https://repology.org/metapackage/bfs/versions.

meta.description for bfs is: '"A breadth-first version of the UNIX find command"'.

Release on GitHub

Compare changes on GitHub

Checks done (click to expand)
Rebuild report (if merged into master) (click to expand)

4 total rebuild path(s)

1 package rebuild(s)

1 x86_64-linux rebuild(s)
1 i686-linux rebuild(s)
1 x86_64-darwin rebuild(s)
1 aarch64-linux rebuild(s)

First fifty rebuilds by attrpath
bfs

Instructions to test this update (click to expand)

Either download from Cachix:

nix-store -r /nix/store/5b4zi292jgibpahgc4ff7pw9mm1zw456-bfs-1.4 \
  --option binary-caches 'https://cache.nixos.org/ https://r-ryantm.cachix.org/' \
  --option trusted-public-keys '
  r-ryantm.cachix.org-1:gkUbLkouDAyvBdpBX0JOdIiD2/DP1ldF3Z3Y6Gqcc4c=
  cache.nixos.org-1:6NCHdD59X431o0gWypbMrAURkbJ16ZPMQFGspcDShjY=
  '

(r-ryantm's Cachix cache is only trusted for this store-path realization.)

Or, build yourself:

nix-build -A bfs https://github.com/r-ryantm/nixpkgs/archive/8a3c824fead236e3f8bfe5e86c578d25a8a758e7.tar.gz

After you've downloaded or built it, look at the files and if there are any, run the binaries:

ls -la /nix/store/5b4zi292jgibpahgc4ff7pw9mm1zw456-bfs-1.4
ls -la /nix/store/5b4zi292jgibpahgc4ff7pw9mm1zw456-bfs-1.4/bin

cc @yesbox for testing.

@tomberek
Copy link
Contributor

left a comment

Linking fails on Darwin. This failed in the past as well, so it is not a regression. 1.4 seems to be fully functional in MacPorts, so it seems it should be possible for us to fix Darwin support.

@nixos-discourse

This comment has been minimized.

Copy link

commented Apr 30, 2019

This pull request has been mentioned on Nix community. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/12

@tavianator

This comment has been minimized.

Copy link

commented May 2, 2019

My guess is the Darwin failure is due to make release using LTO. This looks like the same issue: "#19098"

I'm not sure how to fix the toolchain, but it could be worked around by just running plain make, which will pick up CFLAGS from the environment.

bfs: 1.3.3 -> 1.4.1
Semi-automatic update generated by
https://github.com/ryantm/nixpkgs-update tools. This update was made
based on information from
https://repology.org/metapackage/bfs/versions

@marsam marsam force-pushed the r-ryantm:auto-update/bfs branch from 8a3c824 to 21b1d6e May 12, 2019

@marsam marsam merged commit 079b004 into NixOS:master May 12, 2019

@r-ryantm r-ryantm deleted the r-ryantm:auto-update/bfs branch May 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.