Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Epson network scanners #60568

Merged
merged 2 commits into from Jun 12, 2019

Conversation

Projects
None yet
4 participants
@booxter
Copy link
Contributor

commented May 1, 2019

No description provided.

@booxter

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2019

I've tested it based on release-19.03. I don't have a setup with master to validate cherry-pick works on master. Is there a procedure to validate a patch against master except by upgrading to master? For a separate standing packages it's easy to install it with nix-env but this package involves configuration options and I am not yet sure how to build with options included but isolated from the host.

@risicle

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Clone another copy of the nixpkgs repo somewhere and do nix-build . -A some.package.attrpath from within it?

@booxter

This comment has been minimized.

Copy link
Contributor Author

commented May 9, 2019

@risicle I can definitely build the package but it's hard to tell if it definitely works with the whole setup (sane config files etc.) unless I build the whole system using master and the PR and try it out.

@risicle

This comment has been minimized.

Copy link
Contributor

commented May 9, 2019

You can take a simple (or complex) machine configuration and build a vm from it https://nixos.wiki/wiki/Cheatsheet#Reuse_a_package_as_a_build_environment which you can just launch with a single command.

@booxter

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@risicle these build tools are amazing! I've just built a VM with my configuration and this branch (that is based on master) and validated that scanimage -L shows the remote scanner and that scanimage > file generates an image.

@booxter

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2019

/assign @symphorien

@symphorien

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

Looks good to me!
I rebuilt my system with these commits rebased on 19.03. My (usb) scanner still works.

@booxter

This comment has been minimized.

Copy link
Contributor Author

commented Jun 11, 2019

@symphorien thanks for checking. How do we get it merged? I believe you are marked as the package maintainer so I hoped you can nudge it in.

@symphorien

This comment has been minimized.

Copy link
Contributor

commented Jun 12, 2019

Sorry, I don't have merge rights. We can only wait for someone who can to notice this PR.

@veprbl

veprbl approved these changes Jun 12, 2019

ntPluginVersion = "1.1.1-1";

buildInputs = [ stdenv.cc.cc.lib ];
nativeBuildInputs = [ autoPatchelfHook ];

This comment has been minimized.

Copy link
@veprbl

veprbl Jun 12, 2019

Member

If this works then, perhaps, other plugins could use this too.

@veprbl veprbl merged commit 35ee15d into NixOS:master Jun 12, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details

rydnr pushed a commit to rydnr/nixpkgs that referenced this pull request Jun 13, 2019

dmvianna added a commit to dmvianna/nixpkgs that referenced this pull request Jun 25, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.