Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dart: 2.0.0 -> 2.2.0 #60607

Closed
wants to merge 2 commits into from
Closed

dart: 2.0.0 -> 2.2.0 #60607

wants to merge 2 commits into from

Conversation

glesica
Copy link

@glesica glesica commented May 1, 2019

Motivation for this change

There are newer versions of Dart available.

Things done

Added 2.1.0, 2.1.1, 2.2.0, and the latest dev channel release of the 2.3.0 series. I'm not actually sure what the dart_stable, dart_old, and dart_dev values are for, I can't actually figure out how to use them other than the fact that they cause the corresponding versions to show up in a query. However, this means 2.2.0 shows up twice, so maybe we ought to drop dart_stable?

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (Fedora 30)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

New versions of Dart are available that contain substantial
improvements.
@fr3fou
Copy link

fr3fou commented Aug 6, 2019

Any news?

@rixed
Copy link
Contributor

rixed commented Nov 17, 2019

There is no maintainer in the meta, so that must not help. I suggest finding one (maybe yourself?)
Then, is it necessary to keep all the old version definitions?

@glesica
Copy link
Author

glesica commented Nov 22, 2019

Not really necessary, no. I was just following the pattern that seemed to exist already. You think just keeping the latest would be fine?

@glesica
Copy link
Author

glesica commented Nov 22, 2019

Speaking of which, I also need to update this to 2.6. I'll do that this weekend.

@rixed
Copy link
Contributor

rixed commented Nov 24, 2019

You think just keeping the latest would be fine?

That's my understanding of the recommended best practices. See https://nixos.org/nixpkgs/manual/#sec-versioning
Also this thread has more info and rationale: #36266

So unless there is value to keep various versions (for instance if several versions are popular that are incompatible) then I would say there should be only the latest version in nixpkgs.

@glesica
Copy link
Author

glesica commented Dec 4, 2019

I'll update it, thanks!

@GRBurst
Copy link
Contributor

GRBurst commented Mar 28, 2020

so this is superseded by #78475

@glesica
Copy link
Author

glesica commented Mar 31, 2020

Perfect, thanks!

@glesica glesica closed this Mar 31, 2020
@glesica glesica deleted the dart-2.3-linux branch March 31, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants