Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

home-assistant: add sonos component dependencies #60853

Closed
wants to merge 0 commits into from

Conversation

@juaningan
Copy link
Contributor

commented May 3, 2019

Motivation for this change

Add required python packages and binding them in the component-packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@FRidh

This comment has been minimized.

Copy link
Member

commented May 4, 2019

@GrahamcOfBorg build python2.pkgs.psonos python3.pkgs.sonos

@dotlambda
Copy link
Member

left a comment

It does not make much sense to merge this before #60217 is merged. So I'll ask you to rebase once that's done.

Show resolved Hide resolved pkgs/development/python-modules/pysonos/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/pysonos/default.nix Outdated

@juaningan juaningan referenced this pull request May 4, 2019

Closed

pytest-cov 2.6.1 #26

@dotlambda dotlambda changed the base branch from master to staging May 7, 2019

@dotlambda
Copy link
Member

left a comment

Please update pysonos to 0.0.13 and re-run parse-requirements.py after rebasing on d280603.

@dotlambda
Copy link
Member

left a comment

Please squash your commits such that there's one called pythonPackages.pysonos: init at 0.0.13 and another one called home-assistant: run parse-requirements.py.

Show resolved Hide resolved pkgs/development/python-modules/pysonos/default.nix Outdated
Show resolved Hide resolved pkgs/development/python-modules/pysonos/default.nix Outdated
@dotlambda

This comment has been minimized.

Copy link
Member

commented May 10, 2019

@GrahamcOfBorg build python2.pkgs.pysonos python3.pkgs.pysonos

@dotlambda dotlambda changed the base branch from staging to master May 20, 2019

@dotlambda dotlambda closed this May 20, 2019

@dotlambda

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Sorry, I f**d up. Let's continue here: #61748

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.