Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perlPackages: fix build packages for non-default perl #60861

Merged
merged 1 commit into from May 8, 2019

Conversation

@volth
Copy link
Contributor

commented May 3, 2019

@aanderse has found a bug #60702 (comment) with compiling some packages using non-default perl (currently there is only 5.29.9 as perldevel).

It seems like a regression after #56019 where perl has been replaced with buildPackages.perl to fix cross-compilation issues, but while perl is overrideable and points to perl of the current context (which could be pkgs.perl, pkgs.perldevel, etc), buildPackages.perl always points to pkgs.buildPackages.perl which is always perl-5.28.

Thus two versions of perl (5.28.2 and 5.29.9) were used simultaneously to build and test some packages which leads to errors.

@illegalprime to test cross-compilation things
@srhb
@rycee

@volth

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

Backport is not needed, #56019 is not in release-19.03

@volth

This comment has been minimized.

Copy link
Contributor Author

commented May 3, 2019

@GrahamcOfBorg build perlPackages.URI
@GrahamcOfBorg build perldevelPackages.URI
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey
@GrahamcOfBorg build pkgsCross.armv7l-hf-multiplatform.perldevelPackages.TermReadKey

@aanderse

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

@volth from my perspective this looks good. Who do we need to engage to authoritatively say it's good to merge, though?

@grahamc

This comment has been minimized.

Copy link
Member

commented May 8, 2019

I'm inclined to trust @volth to authoritatively say it is good to merge.

@grahamc grahamc merged commit 0a64e79 into NixOS:staging May 8, 2019

23 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
perlPackages.URI on aarch64-linux Success
Details
perlPackages.URI on x86_64-linux Success
Details
perlPackages.URI, perldevelPackages.URI, pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey, pkgsCross.armv7l-hf-multiplatform.perldevelPackages.TermReadKey on aarch64-linux Success
Details
perlPackages.URI, perldevelPackages.URI, pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey, pkgsCross.armv7l-hf-multiplatform.perldevelPackages.TermReadKey on x86_64-linux Success
Details
perldevelPackages.URI on aarch64-linux Success
Details
perldevelPackages.URI on x86_64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey on aarch64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.perlPackages.TermReadKey on x86_64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.perldevelPackages.TermReadKey on aarch64-linux Success
Details
pkgsCross.armv7l-hf-multiplatform.perldevelPackages.TermReadKey on x86_64-linux Success
Details
@volth

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

#61143 was a second commit here which I isolated to a separated PR to make them both simpler and understandable in case of regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.