Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix many gstreamer packages on Darwin #60922
Motivation for this change
See commit messages.
Darwin evaluation was accidentally broken in the past.
One commit fixes the evaluation, the other one fixes as many packages to build with as many features as I had time to fix.
A couple things still don't work, for example the
I'm not an OSX user, I just want to make #54398 as useful as possible.
During the 1.14 -> 1.15 upgrade, lots of stuff stopped working because gstreamer changed what features are enabled by default and which ones are automatically turned on/off via pkgconfig dependency detection. This resulted in the `gstreamer` ("core" attribute in nixpkgs) package to have only 15 of its previous 163 build targets enabled, and downstream packages breaking correspondingly. To ease maintainability and to ensure users will find the expected features available (and when not, will see in the nix file why not), we now pass the `-Dauto_features=enabled` Meson build flag to all gstreamer builds, which sets all `auto` dependencies to `enabled`, and we explicitly disable those that we can't build. This means in particular that `gst-plugins-bad` now has vastly more integrations (namely all for which nixpkgs has libraries available).
Changes needed: * core: dbghelp disabled as it's not needed * core: Fixed script not being executable and skipped by patchShebangs * base: gtk_doc disabled because of wayland symbol error * ges: Patch removed that was merged upstream: https://bugzilla.gnome.org/show_bug.cgi?id=794856#c16
…ilds. Commit be38210 broke evaluation on Darwin because it added these unconditional buildInputs that don't evaluate on Darwin: libnice librdf lilv lv2 serd sord sratom This commit fixes it, and also fixes recently-added new dependencies for other packages accordingly. It further fixes the build of many gstreamer packages on Darwin.
Amended to fix build of
This pull request has been mentioned on Nix community. There might be relevant details there:
Well looks like I was wrong, support for that Macbook Air ends at OSX 10.10 (thanks planned obsolescence for perfectly fast hardware, Apple!
I think this can be closed, becase around #70690 (comment) I see my commit from this PR cherry-picked.
It doesn't seem to update all the files I do here, but that's probably OK.