qscintilla: add qtmacextras to propagatedBuildInputs on darwin #61001
+4
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Motivation for this change
I found that
qgis
failed to build on macOS becausepython3Packages.qscintilla-qt5
was failing. The problem was thatqtmacextras
needs to be in thebuildInputs
ofpython3Packages.qscintilla-qt5
. This change addsqtmacextras
topropagatedBuildInputs
ofqscintilla
. I wasn't sure if this is the right change, or if I should addqtmacextras
directly topython3Packages.qscintilla-qt5
.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nix-review --run "nix-review wip"
./result/bin/
)nix path-info -S
before and after)