Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rngd: harden service config, settings from arch #61032

Merged
merged 1 commit into from May 11, 2019

Conversation

@dtzWill
Copy link
Member

@dtzWill dtzWill commented May 6, 2019

Motivation for this change

Noticed while investigating behavior by comparing
settings used across distributions.

Conceivably impacts anyone using NIST beacon or something (?!)
but that's not a supported configuration anyway AFAIK.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@c0bw3b
Copy link
Contributor

@c0bw3b c0bw3b commented May 6, 2019

By default we build rng-tools without NIST beacon support but there is a switch to enable it.
Still this is a good addition to the service module. It just need to be tested to check it can still see and use all available sources (hwrng, RDRAND, jitterentropy, ...)

@JohnAZoidberg
Copy link
Member

@JohnAZoidberg JohnAZoidberg commented May 6, 2019

I think it's alright that the NIST beacon doesn't work. The description of this module says: "adds entropy from hardware sources of randomness". I would assume it doesn't include network access. And also the NIST beacon shouldn't be used for real world use.

@dtzWill dtzWill force-pushed the feature/rngd-harden branch from 0c4112e to e5d049e May 8, 2019
@c0bw3b c0bw3b merged commit e8d7f17 into NixOS:master May 11, 2019
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants