Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elasticsearchPlugins: fix plugins, add s3-repository and gcs-repository plugin #61045

Merged

Conversation

@offlinehacker
Copy link
Contributor

@offlinehacker offlinehacker commented May 6, 2019

Motivation for this change

Fixing of elasticsearch plugins and s3 and gcs repo integration

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@offlinehacker offlinehacker force-pushed the pkgs/elasticsearch/plugins-refactor branch 2 times, most recently from c9821ca to 6b925af May 11, 2019
@offlinehacker
Copy link
Contributor Author

@offlinehacker offlinehacker commented May 11, 2019

@offlinehacker offlinehacker force-pushed the pkgs/elasticsearch/plugins-refactor branch from 6b925af to 18c517e May 11, 2019
@offlinehacker
Copy link
Contributor Author

@offlinehacker offlinehacker commented May 11, 2019

I'm merging this as it fixes elasticsearch plugins.

@offlinehacker offlinehacker force-pushed the pkgs/elasticsearch/plugins-refactor branch from 18c517e to e3f6239 May 11, 2019
@offlinehacker
Copy link
Contributor Author

@offlinehacker offlinehacker commented May 11, 2019

@GrahamcOfBorg build elasticsearchPlugins elasticsearchPlugins7

@offlinehacker offlinehacker merged commit af97161 into NixOS:master May 11, 2019
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants