Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.datasette: init at 0.27 #61085

Merged
merged 9 commits into from May 8, 2019

Conversation

@costrouc
Copy link
Contributor

commented May 7, 2019

Motivation for this change

Inspired by pycon talk about web server for sqlite databases

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@costrouc costrouc requested a review from FRidh as a code owner May 7, 2019

@costrouc costrouc force-pushed the costrouc:python-datasette-init branch from e6fd532 to 061d688 May 7, 2019

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

@GrahamcOfBorg build python3Packages.datasette python3Packages.csvc-to-sqlite

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented May 7, 2019

nix review passes

Result of nix-review pr 61085 1

12 package were build:
  • csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • datasette (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.uvloop (python37Packages.csvs-to-sqlite ,python37Packages.datasette)

costrouc added some commits May 7, 2019

@costrouc costrouc force-pushed the costrouc:python-datasette-init branch 2 times, most recently from dfbeac6 to 35d3830 May 8, 2019

costrouc added some commits May 7, 2019

@costrouc costrouc force-pushed the costrouc:python-datasette-init branch from 35d3830 to 8a39315 May 8, 2019

@costrouc

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Result of nix-review pr 61085 1

12 package were build:
  • csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • datasette (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.csvs-to-sqlite (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python27Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.httptools (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.py-lru-cache (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.pytest-sugar (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.sanic (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
  • python37Packages.uvloop (python37Packages.csvs-to-sqlite ,python37Packages.datasette)
@risicle

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Would you be able to shuffle the order of the commits so that the dependent packages come after their dependencies? This way there aren't any "broken" intermediary commit states, which makes bisecting nicer for everyone.

@risicle

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

(nox-review builds for me, executables basically work, non-nixos linux x86_64)

@marsam marsam merged commit 7c7ccd5 into NixOS:master May 8, 2019

13 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@marsam

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Sorry for the delay, looks good. Thanks @costrouc, @risicle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.