Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitAndTools.gitstatus: init at 20190506 #61116

Merged
merged 1 commit into from May 30, 2019

Conversation

@mmlb
Copy link
Contributor

commented May 8, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -127,6 +127,8 @@ let

gitflow = callPackage ./gitflow { };

gitflow = callPackage ./gitstatus { };

This comment has been minimized.

Copy link
@teto

teto May 8, 2019

Contributor

gitstatus I think :p

This comment has been minimized.

Copy link
@mmlb

mmlb May 9, 2019

Author Contributor

derp :)

This comment has been minimized.

Copy link
@mmlb

mmlb May 9, 2019

Author Contributor

Thats what I get for not cherry-picking from my other branch :|

This comment has been minimized.

Copy link
@mmlb

mmlb May 9, 2019

Author Contributor

fixed

{callPackage, stdenv, fetchFromGitHub, ...}:

stdenv.mkDerivation rec {
name = "gitstatus-${version}";

This comment has been minimized.

Copy link
@teto

teto May 8, 2019

Contributor

use pname = "gistatus" instead, mkDerivation will generate the same name automatically.

This comment has been minimized.

Copy link
@mmlb

mmlb May 9, 2019

Author Contributor

oic!

This comment has been minimized.

Copy link
@mmlb

mmlb May 9, 2019

Author Contributor

fixed

@mmlb mmlb force-pushed the mmlb:add-gitstatus branch from 8c4dbc5 to c0b5dbb May 12, 2019

@nlewo

This comment has been minimized.

Copy link
Member

commented May 12, 2019

@GrahamcOfBorg gitAndTools.gitstatus

@mmlb

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

@nlewo pinging, requested changes are in

@mmlb

This comment has been minimized.

Copy link
Contributor Author

commented May 28, 2019

@nlewo @teto ping

@nlewo
Copy link
Member

left a comment

Oups! Sorry ;)
Still minor review, otherwise LGTM.


stdenv.mkDerivation rec {
pname = "gitstatus";
version = "20190506";

This comment has been minimized.

Copy link
@nlewo

nlewo May 28, 2019

Member

According to the manual:

Suggested change
version = "20190506";
version = "unstable-2019-05-06";

This comment has been minimized.

Copy link
@mmlb

mmlb May 28, 2019

Author Contributor

@nlewo done

@mmlb mmlb force-pushed the mmlb:add-gitstatus branch from c0b5dbb to c9d1a0d May 28, 2019

@nlewo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

@GrahamcOfBorg build gitAndTools.gitstatus

@nlewo

This comment has been minimized.

Copy link
Member

commented May 29, 2019

This doesn't build on darwin. Could you please either fix the build for darwin or restrict the supported platforms (see meta.platforms in the nixpkgs manual).

@mmlb

This comment has been minimized.

Copy link
Contributor Author

commented May 29, 2019

@nlewo the build log indicates an issue with clang not being able to build a binary... which indicates ci env issues? I'd rather not just blacklist darwin, but don't really know how to proceed.

@nlewo

This comment has been minimized.

Copy link
Member

commented May 30, 2019

Ok. I don't think we can do more on this darwin error. So, let's merge it as it is currently.
Thx!

@nlewo nlewo merged commit 3213c6c into NixOS:master May 30, 2019

15 of 16 checks passed

gitAndTools.gitstatus on x86_64-darwin Failure
Details
Evaluation Performance Report Evaluator Performance Report
Details
gitAndTools.gitstatus on aarch64-linux Success
Details
gitAndTools.gitstatus on x86_64-linux Success
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
@mmlb

This comment has been minimized.

Copy link
Contributor Author

commented May 30, 2019

:toot:

@mmlb mmlb deleted the mmlb:add-gitstatus branch May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.