Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added database from vim-awesome #61118

Closed
wants to merge 1 commit into from

Conversation

@SRGOM
Copy link
Contributor

commented May 8, 2019

Database url: https://github.com/vim-awesome/vim-awesome/releases/download/v1.2/rethinkdb_dump_2016-04-14.tar.gz

I added this because I think vim awesome is a great list, they include plugins by using statistics from publicly available dotfiles on github.

There are some repos which have duplicate names, e.g. mileszs/ack.vim and tyok/ack.vim. I am very new to nix so couldn't figure how this would be handled in the derivation generation but if this is going to be an issue then I can remove the duplicates.

@SRGOM

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

@teto, Hi, I notice from #65276 that you have merge ability. I wasn't sure who could merge but now that I know it's you, and that you added a 'congratulations' emoji to the PR, I assume the problem is that my commit message doesn't follow the guidelines? If I fix the commit message and the conflicts, would you be able to merge?

Thanks

@teto

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

Hi, I am not a "core" member of nixos so I tend to merge only small, non convtroversial/dangerous PR. This PR adds lots of packages in one go and I don't know if that's something the nixos team desires (may trigger many new GH issues since these packages have not been tested, has a hosting cost etc).
I believe it should be fine.
@timokau has some more mileage so his opinion might be of interest.

@SRGOM

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

Alright, thank you for chipping in. You have been very valuable guide in the past. I'll wait to hear from @timokau

ujihisa/unite-gem
ujihisa/unite-locate
ujihisa/vimshell-ssh
urso/dotrc

This comment has been minimized.

Copy link
@Mic92

Mic92 Jul 26, 2019

Contributor

Some of repositories listed here are just dotfiles instead of plugins.

ujihisa/vimshell-ssh
urso/dotrc
uu59/vim-herokudoc-theme
vain/dotfiles-pub

This comment has been minimized.

Copy link
@Mic92

Mic92 Jul 26, 2019

Contributor

This one too.

@timokau

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

I'm also not entirely sure we want this. Up until now our criterion for inclusion was "at least on person wants it bad enough to make a PR" and I think that has worked pretty well. At least it guarantees that one person has verified it actually works.

If we just automatically add a bunch of plugins, some of which aren't even plugins as @Mic92 has pointed out, that could cost users some time when a plugin doesn't work and they assume the issue is on their side. It will also add overhead for automated updates and bigger diffs.

I don't think its necessarily horrible, I'm just not quite convinced that the added value outweights the added inconvenience. I'm not blocking this, if anyone with permission (including @teto of course) thinks this should be merged, that is fine by me.

I'd feel better about this if it was maybe just the top-ranking plugins and every plugin was verified at least somewhat.

@Mic92

This comment has been minimized.

Copy link
Contributor

commented Jul 26, 2019

I agree with @timokau concerns.

@SRGOM

This comment has been minimized.

Copy link
Contributor Author

commented Jul 27, 2019

Thinking about it, its probably a fair criterion. On the other hand, please bear in mind that there are things that NixOS makes so easy that a lot of people have no incentive to spend time checking in upstream. And also the database has been compiled keeping in mind lots of .vimrc. I will close for now though. Thank you for looking and for maintaing NixOS in general.

@SRGOM SRGOM closed this Jul 27, 2019

@timokau

This comment has been minimized.

Copy link
Member

commented Jul 27, 2019

Thank you for putting your time into this. Although we can't merge everything, experimentation is always valuable and appreciated :)

@SRGOM

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

No, thank you. You guys have made linux so usable that 'it just works' and I don't even evangelize it anymore.

For next time, how do you handle two separate plugins with the same name? Same timokau/vim-p99 and srgom/vim-p99? Is it alright if I had them both in the file?

@timokau

This comment has been minimized.

Copy link
Member

commented Jul 28, 2019

No, thank you. You guys have made linux so usable that 'it just works' and I don't even evangelize it anymore.

:)

For next time, how do you handle two separate plugins with the same name? Same timokau/vim-p99 and srgom/vim-p99? Is it alright if I had them both in the file?

That is currently not supported by our automated vim-plugin update infrastructure (see pkgs/misc/vim-plugins/update.py). That script strips the owner and just generates a package for p99.

If you needed that, you could either add a package manually (see pkgs/misc/vim-plugins/generated.nix) and keep it up-to-date manually or improve the update script to allow aliasing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.