Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taskell: 1.4.2 -> 1.4.3 #61126

Merged
merged 2 commits into from May 15, 2019

Conversation

@matthiasbeyer
Copy link
Contributor

commented May 8, 2019

Motivation for this change

Followup for #60363

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions (centos)
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@dtzWill and @BenBals here we go.

taskell: 1.4.2 -> 1.4.3
Signed-off-by: Matthias Beyer <mail@beyermatthias.de>
@BenBals

This comment has been minimized.

Copy link
Contributor

commented May 8, 2019

Thanks for the mention.

Reviewed points
  • package path fits guidelines
  • package name fits guidelines
  • package version fits guidelines
  • package build on Linux nixos-beb 4.19.37 #1-NixOS SMP Sat Apr 27 07:36:41 UTC 2019 x86_64 GNU/Linux
  • executables tested on Linux nixos-beb 4.19.37 #1-NixOS SMP Sat Apr 27 07:36:41 UTC 2019 x86_64 GNU/Linux
  • meta.description is set and fits guidelines
  • meta.license fits upstream license
  • meta.platforms is set
  • meta.maintainers is set
  • build time only dependencies are declared in nativeBuildInputs
  • source is fetched using the appropriate function
  • phases are respected
  • patches that are remotely available are fetched with fetchpatch
Possible improvements
Comments

Is meta.maintainers unset or am I just missing it?

@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

Hmh all meta info is missing. Will fix this ... Maybe tomorrow tho

@matthiasbeyer matthiasbeyer force-pushed the matthiasbeyer:update-taskell branch from 1d8e2b9 to c81ba55 May 8, 2019

@matthiasbeyer

This comment has been minimized.

Copy link
Contributor Author

commented May 8, 2019

@GrahamcOfBorg build taskell

@marsam marsam force-pushed the matthiasbeyer:update-taskell branch from c81ba55 to 3e6ac2c May 15, 2019

@marsam marsam merged commit 1d9aaf6 into NixOS:master May 15, 2019

16 checks passed

Evaluation Performance Report Evaluator Performance Report
Details
grahamcofborg-eval ^.^!
Details
grahamcofborg-eval-check-maintainers matching changed paths to changed attrs...
Details
grahamcofborg-eval-check-meta config.nix: checkMeta = true
Details
grahamcofborg-eval-darwin nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A darwin-tested
Details
grahamcofborg-eval-nixos nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release-combined.nix -A tested
Details
grahamcofborg-eval-nixos-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A manual
Details
grahamcofborg-eval-nixos-options nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./nixos/release.nix -A options
Details
grahamcofborg-eval-nixpkgs-manual nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A manual
Details
grahamcofborg-eval-nixpkgs-tarball nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A tarball
Details
grahamcofborg-eval-nixpkgs-unstable-jobset nix-instantiate --arg nixpkgs { outPath=./.; revCount=999999; shortRev="ofborg"; } ./pkgs/top-level/release.nix -A unstable
Details
grahamcofborg-eval-package-list nix-env -qa --json --file .
Details
grahamcofborg-eval-package-list-no-aliases nix-env -qa --json --file . --arg config { allowAliases = false; }
Details
taskell on aarch64-linux Success
Details
taskell on x86_64-darwin Success
Details
taskell on x86_64-linux Success
Details
@marsam

This comment has been minimized.

Copy link
Contributor

commented May 15, 2019

I fixed a minor issue in the last commit, I hope you don't mind
Thanks!

@matthiasbeyer matthiasbeyer deleted the matthiasbeyer:update-taskell branch May 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.